Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor munch #1254

Closed
sgillies opened this issue Apr 21, 2023 · 1 comment
Closed

Vendor munch #1254

sgillies opened this issue Apr 21, 2023 · 1 comment
Assignees
@sgillies
Labels
bug upstream
Milestone
1.9.4

Comments

@sgillies
Copy link
Member

Munch uses pkg_resources and thus is causing deprecation warnings from setuptools. There's no stable version of munch that fixes this and no sign that there will be one. My solution is to vendor munch and remove the use of pkg_resources.
@sgillies sgillies added this to the 1.9.4 milestone Apr 21, 2023
@sgillies sgillies self-assigned this Apr 21, 2023
sgillies added a commit that referenced this issue Apr 21, 2023
@sgillies
Vendor munch and hard code its version
97b07c6 
Resolves #1254
@sgillies sgillies mentioned this issue Apr 21, 2023
Merged
sgillies added a commit that referenced this issue Apr 21, 2023
@sgillies
Vendor munch and hard code its version (#1255)
eb383cb 
* Vendor munch and hard code its version

Resolves #1254

* Remove munch dependency and update change log
@nekopsykose
Copy link

munch 3.0 now replaced pkg_resources with importlib metadata so you can devendor it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgillies sgillies

Labels
bug upstream
Projects
None yet
Milestone
1.9.4
Development

No branches or pull requests
2 participants
@sgillies @nekopsykose