Log a warning message when identically named fields are found #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
commented
Feb 9, 2023
| name. When encountered, a warning message is logged and the | ||
| field is skipped. | ||
|
|
||
| """ |
There was a problem hiding this comment.
I took the opportunity to make get_schema more readable. We'll be making future changes to it.
sgillies
commented
Feb 9, 2023
| i, | ||
| key | ||
| ) | ||
| continue |
There was a problem hiding this comment.
This preserves existing behavior, field skipping, but adds a warning level log message. I decided against raising a warning, because there's nothing you can do about the fields and schema if you were to handle the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1178