Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Always run on push to master branch #326

Closed
wants to merge 1 commit into from

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Jul 11, 2024

Currently the CI doesn't run when a commit is pushed to the master branch, except if the configuration itself is changed. This is a bit strange, because you would always want to validate that the master branch is testing properly, especially with more complex squash / rebase merges.

Currently the CI doesn't run when a commit is pushed to the master branch, except if the configuration itself is changed. This is a bit strange, because you would always want to validate that the master branch is testing properly, especially with more complex squash / rebase merges.
@mwtoews
Copy link
Member

mwtoews commented Jul 11, 2024

I saw this too, and already have #325 that does the same as this PR.

#299 is to blame for this one, as I naively split one workflow into two.

@EwoutH
Copy link
Contributor Author

EwoutH commented Jul 11, 2024

Didn't saw that one, closing in favor of #325!

@EwoutH EwoutH closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants