Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: better configuration for discovery providers #314

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Apr 29, 2024

SetConfig has been removed from the provider interface

closes #299
closes #300

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 92.20779% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.71%. Comparing base (f1d8604) to head (c1bf3b3).

Files Patch % Lines
discovery/mdns/discovery.go 72.72% 1 Missing and 2 partials ⚠️
discovery/nats/discovery.go 77.77% 1 Missing and 1 partial ⚠️
discovery/dnssd/discovery.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   87.16%   86.71%   -0.46%     
==========================================
  Files          31       33       +2     
  Lines        3186     3055     -131     
==========================================
- Hits         2777     2649     -128     
+ Misses        296      295       -1     
+ Partials      113      111       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey merged commit 6524ea0 into main Apr 29, 2024
1 of 2 checks passed
@Tochemey Tochemey deleted the issue-300 branch April 29, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant