Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean the addressing engine #460

Merged
merged 7 commits into from
Sep 7, 2024
Merged

refactor: clean the addressing engine #460

merged 7 commits into from
Sep 7, 2024

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Sep 7, 2024

  1. Cleanup the actor addressing engine
  2. Rename GossipPort to DiscoveryPort in discovery.Node (breaking changes)
  3. Rename ClusterConfig method WithGossipPort to WithDiscoveryPort (breaking changes)
  4. Rename ClusterConfig method GossipPort() to DiscoveryPort() (breaking changes)
  5. Rename kubernetes config GossipPortName to DiscoveryPortName (breaking changes)

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 93.85113% with 19 lines in your changes missing coverage. Please review.

Project coverage is 86.98%. Comparing base (524330a) to head (9e7bef9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
actors/pid.go 89.15% 8 Missing and 1 partial ⚠️
actors/redistribution.go 53.84% 2 Missing and 4 partials ⚠️
actors/actor_system.go 96.87% 1 Missing and 1 partial ⚠️
address/address.go 97.64% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   86.62%   86.98%   +0.35%     
==========================================
  Files          47       46       -1     
  Lines        3581     3557      -24     
==========================================
- Hits         3102     3094       -8     
+ Misses        339      330       -9     
+ Partials      140      133       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey merged commit 1489243 into main Sep 7, 2024
2 checks passed
@Tochemey Tochemey deleted the issue-x branch September 7, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant