Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose an API for custom mailboxes #479

Merged
merged 5 commits into from
Sep 28, 2024
Merged

feat: expose an API for custom mailboxes #479

merged 5 commits into from
Sep 28, 2024

Conversation

Tochemey
Copy link
Owner

@Tochemey Tochemey commented Sep 28, 2024

closes #478

  • Expose mailbox API
  • Implement UnboundedMailbox using mpsc queue which is the default mailbox
  • Implement BoundedMailbox using the ring buffer queue
  • Add a SpawnOption to spawn actor with custom mailbox if needed
  • Add some performance enhancement
  • Add benchmark code for both UnboundedMailbox and BoundedMailbox

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.26%. Comparing base (9343db4) to head (d0a48b5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
actors/pid.go 91.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
+ Coverage   88.03%   88.26%   +0.22%     
==========================================
  Files          43       45       +2     
  Lines        3444     3518      +74     
==========================================
+ Hits         3032     3105      +73     
- Misses        293      294       +1     
  Partials      119      119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tochemey Tochemey merged commit 6d8ec14 into main Sep 28, 2024
3 checks passed
@Tochemey Tochemey deleted the issue-478 branch September 28, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Expose an API for custom mailboxes
1 participant