PacketEvents 2.4.0 and Minecraft 1.21 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's not really much point in making classes for Bogged and Breeze meta if there's no attributes in them |
Yeah I know, but that is also the case for other metas that already exist on the project, I thought adding them would make no harm, plus some people may assume that a meta exists for every entity type and may end up confused when they don't find one, that's mostly why I added them. |
|
Ooh that's true! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PacketEvents 2.4.0 as well as Minecraft 1.21, though the tests I used aren't included on it but will be included on another one so they can be evaluated separately, BoggedMeta and BreezeMeta don't really add anything specific to their mob types as I wasn't able to find documentation about them.
Further testing should be done to be able to tell if this is actually stable on 1.21, but I actually used pretty much every method from the MetaOffsetConverter class on 1.21 and everything seemed to work fine.