refactor variable names as per sonar suggestion

Together-Java · Mar 6, 2024 · 9f9f2d1 · 9f9f2d1
1 parent 5595c19
commit 9f9f2d1
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/application/src/main/java/org/togetherjava/tjbot/features/help/HelpSystemHelper.java b/application/src/main/java/org/togetherjava/tjbot/features/help/HelpSystemHelper.java
@@ -148,9 +148,9 @@ RestAction<Message> constructChatGptAttempt(ThreadChannel threadChannel,
         String answer = chatGPTAnswer.orElseThrow();
         SelfUser selfUser = threadChannel.getJDA().getSelfUser();
 
-        int MESSAGE_CHARACTER_LIMIT = MessageEmbed.DESCRIPTION_MAX_LENGTH;
-        if (answer.length() > MESSAGE_CHARACTER_LIMIT) {
-            answer = answer.substring(0, MESSAGE_CHARACTER_LIMIT);
+        int responseCharLimit = MessageEmbed.DESCRIPTION_MAX_LENGTH;
+        if (answer.length() > responseCharLimit) {
+            answer = answer.substring(0, responseCharLimit);
         }
 
         MessageEmbed responseEmbed = generateGptResponseEmbed(answer, selfUser, originalQuestion);
@@ -162,11 +162,11 @@ RestAction<Message> constructChatGptAttempt(ThreadChannel threadChannel,
     public MessageEmbed generateGptResponseEmbed(String answer, SelfUser selfUser, String title) {
         String responseByGptFooter = "- AI generated response";
 
-        int TITLE_EMBED_LIMIT = MessageEmbed.TITLE_MAX_LENGTH;
+        int embedTitleLimit = MessageEmbed.TITLE_MAX_LENGTH;
         String capitalizedTitle = Character.toUpperCase(title.charAt(0)) + title.substring(1);
 
-        String titleForEmbed = capitalizedTitle.length() > TITLE_EMBED_LIMIT
-                ? capitalizedTitle.substring(0, TITLE_EMBED_LIMIT)
+        String titleForEmbed = capitalizedTitle.length() > embedTitleLimit
+                ? capitalizedTitle.substring(0, embedTitleLimit)
                 : capitalizedTitle;
 
         return new EmbedBuilder()