Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC Activity command crash fix #300 #343

Merged
merged 29 commits into from
Jan 18, 2022
Merged

VC Activity command crash fix #300 #343

merged 29 commits into from
Jan 18, 2022

Commits on Jan 13, 2022

  1. Added: MAX_AGE_DURATION - This converts seconds to days (7) Being max… 

    …imum.

Added: .setRequiredRange(1, TimeUnit.DAYS.toSeconds(MAX_AGE_DURATION)));
sets required range between 1 and 7 days.
    @Budbomber
    Budbomber committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    8fbb2c2 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Added: MAX_AGE_DURATION_ONE_WEEK sets the duration the max duration i… 

    …n seconds.

Added to option MAX_AGE_OPTION: .setRequiredRange(1,NAX_DURATION_ONE_WEEK));
sets required range between 1 and 7 days in seconds
    @Budbomber
    Budbomber committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3e718a7 View commit details
    Browse the repository at this point in the history

  2. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java


Changed, MAX_DURATION_ONE_WEEK to more readable, MAX_VALUE_MAX_AGE, and used ChronoUnit to convert seconds to days.

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    903fcf6 View commit details
    Browse the repository at this point in the history

  3. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java


More readable, removed irrelevant comment

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    2e97eda View commit details
    Browse the repository at this point in the history

  4. Added: MAX_AGE_DURATION_ONE_WEEK sets the duration the max duration i… 

    …n seconds.

Added to option MAX_AGE_OPTION: .setRequiredRange(1,NAX_DURATION_ONE_WEEK));
sets required range between 1 and 7 days in seconds
    @Budbomber
    Budbomber committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    ff8f11c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/develop' into develop 

    # Conflicts:
#	application/src/main/java/org/togetherjava/tjbot/commands/basic/VcActivityCommand.java
    @Budbomber
    Budbomber committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    0756745 View commit details
    Browse the repository at this point in the history

  6. Cleaned up code, Added MAX_USES_MAX VALUE, reformatted MAX_AGE_MAX_VA… 

    …LUE to more readable TimeUnit
    @Budbomber
    Budbomber committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    9ccf518 View commit details
    Browse the repository at this point in the history

  7. Cleaned up code, Added MAX_VALUE_MAX_USES, reformatted MAX_VALUE_MAX_… 

    …AGE to more readable TimeUnit.
    @Budbomber
    Budbomber committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    4d015aa View commit details
    Browse the repository at this point in the history

  8. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java


wrong values (oops)

Co-authored-by: Jonas <jnhrd254@gmail.com>
    @Budbomber @illuminator3
    Budbomber and illuminator3 authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    93b9927 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Taken into account, all the suggestions cleaned up code

    @Budbomber
    Budbomber committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    d760bc0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into develop 

    # Conflicts:
#	application/src/main/java/org/togetherjava/tjbot/commands/basic/VcActivityCommand.java
    @Budbomber
    Budbomber committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    505da9b View commit details
    Browse the repository at this point in the history

  3. Update VcActivityCommand.java 

    Removed useless comment
    @Budbomber
    Budbomber authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    2c7567c View commit details
    Browse the repository at this point in the history

  4. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java


TimeUnit fixed

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    f26b4f2 View commit details
    Browse the repository at this point in the history

  5. Update VcActivityCommand.java 

    Some fixes, (got overhappy with RequiredNonNull)
    @Budbomber
    Budbomber authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    6f5cbbd View commit details
    Browse the repository at this point in the history

  6. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java


Added comments back.

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    825ec48 View commit details
    Browse the repository at this point in the history

  7. Update VcActivityCommand.java 

    removed try - catch
    @Budbomber
    Budbomber authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    5104e73 View commit details
    Browse the repository at this point in the history

  8. Taken into account, all the suggestions cleaned up code

    @Budbomber
    Budbomber committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    2ae2a87 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/develop' into develop 

    # Conflicts:
#	application/src/main/java/org/togetherjava/tjbot/commands/basic/VcActivityCommand.java
    @Budbomber
    Budbomber committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    b57c07b View commit details
    Browse the repository at this point in the history

  10. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    f7d0640 View commit details
    Browse the repository at this point in the history

  11. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    a49095c View commit details
    Browse the repository at this point in the history

  12. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    4ddbd6c View commit details
    Browse the repository at this point in the history

  13. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    29d217f View commit details
    Browse the repository at this point in the history

  14. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    a4ccedb View commit details
    Browse the repository at this point in the history

  15. Update application/src/main/java/org/togetherjava/tjbot/commands/basi… 

    …c/VcActivityCommand.java

Co-authored-by: Tais993 <49957334+Tais993@users.noreply.github.com>
    @Budbomber @Tais993
    Budbomber and Tais993 authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    aeb8e79 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Made changes Zabu requested, typos, Moved declarations, updated doc, … 

    …removed some more empty lines etc.
    @Budbomber
    Budbomber committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    97ed98a View commit details
    Browse the repository at this point in the history

  2. Final changes made, renamed handle method to RequiredOptionIfPresent,… 

    … doc updated.

other format changes.
    @Budbomber
    Budbomber committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    0aca975 View commit details
    Browse the repository at this point in the history

  3. Changes made, remaned maxAge to maxAgeDays, added check in voicechane… 

    …l createInvite for maxAgeDays if null default set otherwise user input set.
    @Budbomber
    Budbomber committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    c11b8ea View commit details
    Browse the repository at this point in the history

  4. Fixed typo's changed text in options to reflect the values set in the… 

    … MAX_AGE_LIMIT & MAX_USES_LIMIT
    @Budbomber
    Budbomber committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    19062bc View commit details
    Browse the repository at this point in the history

  5. Fixed value that was forgotten, input is now in days for UX, and the … 

    …text will display correctly.
    @Budbomber
    Budbomber committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    0a98196 View commit details
    Browse the repository at this point in the history