Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken encoding for unit tests #359

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Fixed broken encoding for unit tests #359

merged 2 commits into from
Feb 2, 2022

Conversation

Zabuzard
Copy link
Member

@Zabuzard Zabuzard commented Feb 1, 2022 •
edited
Loading

Overview

Apparently the previous setup didnt work and unit tests have been executed on the wrong encoding.

Resulting in minor issues, such as unicode usage inside tests not working as expected. For example the following test fails:

assertEquals("\u2022 foo", "• foo");

expected: <• foo> but was: <• foo>
Expected :• foo
Actual :• foo

This fixes the issue.

@Zabuzard Zabuzard added bug Something isn't working priority: low labels Feb 1, 2022
@Zabuzard Zabuzard requested review from a team as code owners February 1, 2022 16:24
@Zabuzard Zabuzard self-assigned this Feb 1, 2022
Zabuzard
Zabuzard commented Feb 1, 2022
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@java-coding-prodigy
Copy link
Contributor

We can merge this now

@Zabuzard Zabuzard merged commit ac1eb59 into develop Feb 2, 2022
@Zabuzard Zabuzard deleted the bug/fix_encoding_for_tests branch February 2, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heatmanofurioso Heatmanofurioso Heatmanofurioso approved these changes

@Tais993 Tais993 Tais993 approved these changes

@java-coding-prodigy java-coding-prodigy java-coding-prodigy approved these changes

@marko-radosavljevic marko-radosavljevic Awaiting requested review from marko-radosavljevic

@illuminator3 illuminator3 Awaiting requested review from illuminator3

Assignees

@Zabuzard Zabuzard

Labels
bug Something isn't working priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zabuzard @java-coding-prodigy @Heatmanofurioso @illuminator3 @Tais993