Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added logger field #366

Merged
merged 5 commits into from
Feb 23, 2022
Merged

Added logger field #366

merged 5 commits into from
Feb 23, 2022

Conversation

java-coding-prodigy
Copy link
Contributor

Fixes #365

Tais993
Tais993 previously approved these changes Feb 6, 2022
View reviewed changes
@krankkkk
Copy link
Contributor

krankkkk commented Feb 6, 2022

As said in the ticket, no reason for the field. So I would close this

marko-radosavljevic
marko-radosavljevic previously requested changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@marko-radosavljevic marko-radosavljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like consistency, so the changes make sense to me. Please check if there is any other place in the codebase where similar thing occurs, so we can align.

I will temporarily put a hold on this PR, because code owner (@krankkkk) disagrees with the changes. ^^

@java-coding-prodigy
Copy link
Contributor Author

Please check if there is any other place in the codebase where similar thing occurs, so we can align.

If I find something will I add that to this PR itself, or another one?

@Tais993
Copy link
Member

Tais993 commented Feb 7, 2022

This PR is fine

@java-coding-prodigy
Copy link
Contributor Author

SonarLint is unhappy that SpringBootServletInitializer(super class of Application in logviewer) has a protected field with the name logger. What do we do about this?

@Tais993
Copy link
Member

Tais993 commented Feb 7, 2022

Time to remove sonarlint since it's giving me mental issues

All loggers should be private, so change that

@java-coding-prodigy
Copy link
Contributor Author

All loggers should be private, so change that

Um, I cannot do that, it is a class from Spring that is causing this issue. Note that the logger there is of class org.apache.commons.logging.Log and not an SLF4J logger

@Tais993
Copy link
Member

Tais993 commented Feb 7, 2022 •
edited
Loading

Rename our logger to log ig?

Just Sonarlint being stupid again

@java-coding-prodigy
Copy link
Contributor Author

Just Sonarlint being stupid again

I could suppress that warning, imo that would be better.

@Tais993
Copy link
Member

Tais993 commented Feb 7, 2022

Then I'd do that

@Tais993 Tais993 mentioned this pull request Feb 22, 2022
Closed
@marko-radosavljevic marko-radosavljevic dismissed their stale review February 23, 2022 13:32

seems like we agreed on how to proceed with this ^^

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Zabuzard Zabuzard merged commit aa68787 into develop Feb 23, 2022
@Zabuzard Zabuzard deleted the add_logger_field branch February 23, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heatmanofurioso Heatmanofurioso Heatmanofurioso left review comments

@Tais993 Tais993 Tais993 approved these changes

@Zabuzard Zabuzard Zabuzard approved these changes

@krankkkk krankkkk Awaiting requested review from krankkkk

@borgrel borgrel Awaiting requested review from borgrel

@illuminator3 illuminator3 Awaiting requested review from illuminator3

@marko-radosavljevic marko-radosavljevic Awaiting requested review from marko-radosavljevic

Assignees

@java-coding-prodigy java-coding-prodigy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generation of logger inside methods
6 participants
@java-coding-prodigy @krankkkk @Tais993 @Heatmanofurioso @Zabuzard @marko-radosavljevic