Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of ALL subcommand on RoleSelectCommand #389

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Removal of ALL subcommand on RoleSelectCommand #389

merged 1 commit into from
Feb 21, 2022

Conversation

Tais993
Copy link
Member

@Tais993 Tais993 commented Feb 18, 2022

This removes the implementation of the ALL subcommand of the option, while keeping the CHOOSE subcommand

Closes #381

@Tais993 Tais993 added good first issue Good for newcomers enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Feb 18, 2022
@Tais993 Tais993 added this to the Improvement phase 1 milestone Feb 18, 2022
@Tais993 Tais993 self-assigned this Feb 18, 2022
@Tais993 Tais993 requested review from a team as code owners February 18, 2022 19:05
Zabuzard
Zabuzard previously approved these changes Feb 18, 2022
View reviewed changes
@Tais993 Tais993 force-pushed the bugfix/381-Remove_role-select_all branch from 64d3a20 to 5fb3147 Compare February 18, 2022 23:31
marko-radosavljevic
marko-radosavljevic reviewed Feb 18, 2022
View reviewed changes
Copy link
Contributor

@marko-radosavljevic marko-radosavljevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at the end of the file. (Also spotless complaining, probably about the same thing)

Zabuzard
Zabuzard previously approved these changes Feb 18, 2022
View reviewed changes
@Tais993
Removal of ALL subcommands on RoleSelectCommand
27979a3 
This removes the ALL subcommand, and "inlines" the CHOOSE subcommand.
@Tais993 Tais993 force-pushed the bugfix/381-Remove_role-select_all branch from 5fb3147 to 27979a3 Compare February 18, 2022 23:44
@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Tais993 Tais993 merged commit 47d6a82 into develop Feb 21, 2022
@Tais993 Tais993 deleted the bugfix/381-Remove_role-select_all branch February 21, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-radosavljevic marko-radosavljevic marko-radosavljevic approved these changes

@Zabuzard Zabuzard Zabuzard approved these changes

@Heatmanofurioso Heatmanofurioso Awaiting requested review from Heatmanofurioso

Assignees

@Tais993 Tais993

Labels
enhance command Modify or improve an existing command or group of commands of the bot good first issue Good for newcomers priority: normal
Projects
None yet
Milestone
Improvement phase 1
Development

Successfully merging this pull request may close these issues.

Remove "/role-select all"
3 participants
@Tais993 @Zabuzard @marko-radosavljevic