Too many roles bugfix role-select #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tais993
added
bug
Tais993
changed the title
Tais993
force-pushed
the
bugfix/role-select-too-many-roles
branch
4 times, most recently
from
88671d5
to
b9392fc
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Zabuzard
requested changes
Mar 2, 2022
application/src/main/java/org/togetherjava/tjbot/commands/SlashCommandAdapter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/SlashCommandAdapter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/SlashCommandAdapter.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Outdated
Show resolved
Hide resolved
Tais993
changed the title
|
any blockers here, or just missing time? |
|
Mainly forgotten about it, and besides that I don't have a lot of free time so yea, someone else can take over if they want, otherwise I'll take a look when I have the time / finished some other things. |
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days. |
The new RoleSelectCommand takes vararg of Roles, and generates the embed based on that.
Zabuzard
force-pushed
the
bugfix/role-select-too-many-roles
branch
from
b9392fc
to
edf680a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Zabuzard
approved these changes
May 28, 2022
Zabuzard
approved these changes
May 28, 2022
Tais993
commented
May 30, 2022
application/src/main/java/org/togetherjava/tjbot/commands/basic/RoleSelectCommand.java
Show resolved
Hide resolved
marko-radosavljevic
approved these changes
May 30, 2022
|
Noice. Merging tomorrow, after doing the mini release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the bug with
/role-selectcrashing on servers having too many roles. And by that closes #400 .It is done by redesigning the command. Instead of having two dialogs (one for the moderator to create the actual dialog and one final for the user to pick), the moderator now picks their options directly as arguments to the command.
Helper
While at it, we introduced a little helper method to
SlashCommandAdapter:generateMultipleOptionsandgetMultipleOptionsByNamePrefixFormer basically takes a given option, such as
"foo"and create a list of optional options:"foo1""foo2""foo3"And latter can parse that back conveniently.