Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorblind support for help system emojis #410

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

Zabuzard
Copy link
Member

@Zabuzard Zabuzard commented Mar 8, 2022

Overview

Implements and closes #409.

As suggested by someone in #tj_suggestions who is red/green colorblind, the existing emojis for the help system status messages are barely distinguishable (🟢 🔴).

This changes the emojis to something that also has a different shape, while still having nice color coding for people who are not colorblind (✅ ❌).

free
busy

Looks for example like this for a colorblind person (deuteranopia):

colorblind

@Zabuzard Zabuzard added good first issue Good for newcomers enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Mar 8, 2022
@Zabuzard Zabuzard added this to the Improvement phase 1 milestone Mar 8, 2022
@Zabuzard Zabuzard self-assigned this Mar 8, 2022
@Zabuzard Zabuzard requested review from a team as code owners March 8, 2022 08:09
@Zabuzard Zabuzard force-pushed the feature/red_green_help_system_colorblind branch from c8f4014 to 1a97228 Compare March 8, 2022 11:55
@interacsion
Copy link
Contributor

as borgrel said here, #409 (comment)

as soon as u change it from colours to symbols you get the problem that symbols need to be interpretted:
does a tick mean the channel is occupied or does it mean that its available? plenty of ppl will think it means the one way and plenty will think it means the other

this could be rather confusing. I would suggest to add a legend to the embed body to make it clearer, maybe something like this:

✅ - free
❌ - used

@Zabuzard
Copy link
Member Author

@MaiTheLord This is already explained in the message in the channel in our real server actually

screen

@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@interacsion
Copy link
Contributor

I see. looks pretty good then!

@Zabuzard
Copy link
Member Author

@MaiTheLord If you like it, feel free to leave an APPROVE in the code review, then I can merge it :)

@Zabuzard Zabuzard merged commit e00ac74 into develop Mar 14, 2022
@Zabuzard Zabuzard deleted the feature/red_green_help_system_colorblind branch March 17, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance command Modify or improve an existing command or group of commands of the bot good first issue Good for newcomers priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace red/green circles from help system (colorblind accessibility)
3 participants