Unit tests for /remind #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zabuzard
force-pushed
the
feature/unit_test_remind
branch
from
0cd0b8c
to
25fff95
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days. |
Zabuzard
added
valid
Zabuzard
force-pushed
the
feature/unit_test_remind
branch
2 times, most recently
from
35dd55f
to
07e8a0b
Compare
Zabuzard
force-pushed
the
feature/unit_test_remind
branch
from
07e8a0b
to
01b3e2e
Compare
* support for `OptionType.INTEGER` in slash command event builder * `getMemberSpy()` * `getJdaMock()` * `createTextChannelSpy` * `getPrivateChannelSpy()` and mocking of private channel in general * `map` and `flatMap` support for `succeeded` and `failed` actions
Zabuzard
force-pushed
the
feature/unit_test_remind
branch
from
259da9c
to
44d76c5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implements and closes #396.
Adds unit tests for
/remind. And while doing so, greatly enhances the capabilities of our JDA mocking suite.Also, this fixes a minor bug with
/remindmixing reminders across guilds.Unit tests
The tests for
RemindCommandcover:The tests for
RemindRoutinecover:JDA mocking suite
The enhancements to the test suite are:
OptionType.INTEGERin slash command event buildergetMemberSpy()getJdaMock()createTextChannelSpygetPrivateChannelSpy()and mocking of private channel in generalmapandflatMapsupport forsucceededandfailedactions