Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made remindme command's implementation global to MessageChannel #422

Merged
merged 1 commit into from
May 3, 2022
Merged

Made remindme command's implementation global to MessageChannel #422

merged 1 commit into from
May 3, 2022

Conversation

Tais993
Copy link
Member

@Tais993 Tais993 commented Mar 29, 2022

In the current implementation of the remindme command the code is meant so it only works in TextChannel's.
The type has been adjusted to MessageChannel to support newschannels, threads, and technically DM's aswell.

Fixes #405

@Tais993 Tais993 requested review from a team as code owners March 29, 2022 13:07
@Tais993 Tais993 mentioned this pull request Mar 29, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Zabuzard
Zabuzard approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work now? if so, approved

@Zabuzard Zabuzard added bug Something isn't working enhance command Modify or improve an existing command or group of commands of the bot priority: normal labels Mar 29, 2022
@Zabuzard Zabuzard added this to the Migrate existing commands milestone Mar 29, 2022
@Tais993
Copy link
Member Author

Tais993 commented Mar 29, 2022 •
edited
Loading

I'm 100% sure that it works, but I haven't had the chance to test it yet.
Worst case threads don't work, while normal channels still work.

Will test tonight when I have the time

@github-actions
Copy link

This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Apr 29, 2022
@Zabuzard
Copy link
Member

@Tais993 does it work? shall we push?

@Zabuzard
Copy link
Member

Zabuzard commented May 3, 2022

Tested, works:

thread test

@Zabuzard Zabuzard merged commit 41829f8 into develop May 3, 2022
@Zabuzard Zabuzard deleted the bugfix/405-thread-support-remindme branch May 3, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Heatmanofurioso Heatmanofurioso Awaiting requested review from Heatmanofurioso

@illuminator3 illuminator3 Awaiting requested review from illuminator3

@marko-radosavljevic marko-radosavljevic Awaiting requested review from marko-radosavljevic

Assignees

@Tais993 Tais993

Labels
bug Something isn't working enhance command Modify or improve an existing command or group of commands of the bot priority: normal stale
Projects
None yet
Milestone
Migrate existing commands
Development

Successfully merging this pull request may close these issues.

/remind doesnt work in threads (NPE)
2 participants
@Tais993 @Zabuzard