Add transfer question feature #885

ankitsmt211 · 2023-09-17T11:23:11Z

add command in message context
can be used to transfer questions
resolves Transfer question Context Command #868

Taz03

cal u explain what this transfer feature is all about?

Taz03 · 2023-09-17T18:09:51Z

...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java

+    private static final String TRANSFER_QUESTION_TITLE_ID = "transferID";
+    private static final String TRANSFER_QUESTION_INPUT_ID = "tranferQuestion";
+    private static final String TRANSFER_QUESTION_TAG = "tags";
+    private static final String QUESTIONS_CHANNEL_ID = "1051826284008853505";


don't hard code this and use longs for channel id

Any suggestions? Get channel by name maybe?

yes, get channel name from config

ankitsmt211 · 2023-09-17T18:22:30Z

cal u explain what this transfer feature is all about?

Any one with role higher or equal to Community Ambassador, can transfer questions from any non-question channel, it will create a modal and prefill all the values. Once submitted, the question will be posted in question forums, original message will be deleted. A dm will be sent to user as a soft warning.

SquidXTV · 2023-09-17T19:15:16Z

Thanks for the work done ❤️

Zabuzard · 2023-09-18T07:23:40Z

please share screenshots of every part of the flow. otherwise its very hard to review the UX part of things

ankitsmt211 · 2023-09-18T09:54:22Z

context menu of any text

Sometimes modal creation fails, but you can either click on reload icon on fail message or do it again.

Prefill modal menu, values can be tweaked.

on Submit, new post is created in questions forum with "Java" tag as default.

Link and info about action is pasted in original channel, also you can see the original message is deleted as well.

DM'd user

Unauthorized user tries to use this command

ankitsmt211 · 2023-09-18T16:25:12Z

If anyone could review if log messages are detailed enough, thanks. Also, i missed something in here "mentioning" author of question in newly created post. I'll add that as well.

...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java

Taz03 · 2023-09-19T04:01:22Z

...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java

+        TextInput transferQuestionTag = TextInput
+            .create(TRANSFER_QUESTION_TAG, "Transfer question tags", TextInputStyle.SHORT)
+            .setValue("Java")
+            .build();


use selection menu, get the list from config

@Taz03 modals only support text input according to JDA doc

so theres no better way to do that?

Theres this StringSelectMenu maybe we can send it before or after the main modal

im not sure if u can make this an ephemeral dialog though. perhaps sth to explore, but i would also be okay if we have that in a second iteration of the feature instead, cause it sounds complex

...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java

Taz03 · 2023-09-19T06:12:36Z

...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java

+        event.getJDA()
+            .getForumChannelById(QUESTIONS_CHANNEL_ID)
+            .createForumPost(forumTitle, forumMessage)
+            .setTags(ForumTagSnowflake.fromId(javaTag.getId()))


y always javaTag

Earlier suggestion was to include a selection menu but didn't seam feasible, used java as it's default and most used tag. Plus this is just a feature to be used as "last resort" clean up tool not to be used primarily.We also wanna make it quicker for moderator to be able to use this quickly without much hassle that's why most values are also prefilled. If any post do not belong to certain category, any helper can see that and change category.

hmm, but this won't work anyways coz u can't just hard code the java tag, it is a config thing. The best option I can think of is having a selection menu

u could read the config. the tags there are sorted by relevance, the first one is always considered the main mega tag

the bot uses that to determine who to ping if multiple tags are selected

this one is still not implemented, ill do this one hopefully soon.

ankitsmt211 · 2023-09-20T23:12:24Z

@Taz03 you mentioned something about getting channel from config, are you suggesting "regex pattern" for helper forum? Maybe get a list of all channels and match with that to get the target channel?

ankitsmt211 · 2023-09-20T23:25:43Z

Not a fan of "three" back to back mentions are being triggered here for OP

on creation of new post
private DM
link to newly created post in source channel

Taz03 · 2023-09-21T05:28:13Z

@Taz03 you mentioned something about getting channel from config, are you suggesting "regex pattern" for helper forum? Maybe get a list of all channels and match with that to get the target channel?

yes

marko-radosavljevic · 2023-09-21T16:40:14Z

Not a fan of "three" back to back mentions are being triggered here for OP
* on creation of new post

* private DM

* link to newly created post in source channel

I agree, let's get rid of the mention in source channel.

That way we don't annoy and confuse the newcomer with mentions all over the place. They only get mentioned where we want them to go, to a correct help thread. Additionally, we keep the source channel clean, and don't interrupt ongoing discussions.

Seems like a cleaner and more streamlined approach. ☺️

ankitsmt211 requested review from a team as code owners September 17, 2023 11:23

Taz03 requested changes Sep 17, 2023

View reviewed changes

Taz03 requested changes Sep 19, 2023

View reviewed changes

Taz03 assigned ankitsmt211 Sep 20, 2023

Taz03 added enhancement New feature or request priority: normal labels Sep 20, 2023

ankitsmt211 closed this Sep 21, 2023

ankitsmt211 mentioned this pull request Sep 22, 2023

reopening transfer feature PR #895

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add transfer question feature #885

Add transfer question feature #885

ankitsmt211 commented Sep 17, 2023

Taz03 left a comment

Taz03 Sep 17, 2023

ankitsmt211 Sep 17, 2023

Taz03 Sep 19, 2023

ankitsmt211 commented Sep 17, 2023

SquidXTV commented Sep 17, 2023

Zabuzard commented Sep 18, 2023

ankitsmt211 commented Sep 18, 2023

ankitsmt211 commented Sep 18, 2023

Taz03 Sep 19, 2023

Zabuzard Sep 19, 2023

Taz03 Sep 19, 2023

Taz03 Sep 19, 2023

Zabuzard Sep 20, 2023

Taz03 Sep 19, 2023

ankitsmt211 Sep 20, 2023 •

edited

Loading

Taz03 Sep 20, 2023

Zabuzard Sep 21, 2023 •

edited

Loading

ankitsmt211 Sep 21, 2023

ankitsmt211 commented Sep 20, 2023

ankitsmt211 commented Sep 20, 2023

Taz03 commented Sep 21, 2023

marko-radosavljevic commented Sep 21, 2023

Add transfer question feature #885

Add transfer question feature #885

Conversation

ankitsmt211 commented Sep 17, 2023

Taz03 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitsmt211 commented Sep 17, 2023

SquidXTV commented Sep 17, 2023

Zabuzard commented Sep 18, 2023

ankitsmt211 commented Sep 18, 2023

ankitsmt211 commented Sep 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitsmt211 Sep 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zabuzard Sep 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitsmt211 commented Sep 20, 2023

ankitsmt211 commented Sep 20, 2023

Taz03 commented Sep 21, 2023

marko-radosavljevic commented Sep 21, 2023

ankitsmt211 Sep 20, 2023 •

edited

Loading

Zabuzard Sep 21, 2023 •

edited

Loading