Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated use of log4j's packages attribute #894

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

SquidXTV
Copy link
Member

About

fixes #887
Removes the deprecated packages attribute in the log4j2.xml.
Now automatically scanning for @Plugin annotation:
https://logging.apache.org/log4j/2.x/manual/plugins.html

In Log4j 2 a plugin is declared by adding a @Plugin annotation to the class declaration. During initialization the Configuration will invoke the PluginManager to load the built-in Log4j plugins as well as any custom plugins.

@SquidXTV SquidXTV requested review from a team as code owners September 21, 2023 18:06
@SquidXTV SquidXTV self-assigned this Sep 21, 2023
@SquidXTV SquidXTV linked an issue Sep 21, 2023 that may be closed by this pull request
Taz03
Taz03 previously approved these changes Sep 22, 2023
Zabuzard
Zabuzard previously approved these changes Sep 22, 2023
@Zabuzard
Copy link
Member

rebase please

@SquidXTV SquidXTV dismissed stale reviews from Zabuzard and Taz03 via 169b6aa September 22, 2023 12:45
@SquidXTV SquidXTV force-pushed the bugfix/deprecated-log4j-packages-attribute branch from 169b6aa to 1e27670 Compare September 22, 2023 13:16
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Zabuzard Zabuzard merged commit 68deee0 into develop Sep 25, 2023
11 checks passed
@Zabuzard Zabuzard deleted the bugfix/deprecated-log4j-packages-attribute branch September 25, 2023 07:03
@Zabuzard Zabuzard mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deprecated Log4J package scanning
3 participants