ChatGPT response Dismiss button

[SquidXTV]

About

closes #897

Adds the dismiss button to the chatgpt response:

[SquidXTV]

Two questions:

1. Is the concurrent arraylist needed in HelpSystemHelper or would a normal one work as well?
2. The event.getMember seems to be @Nullable, should I care? because the filesharing feature didnt care as well

[Zabuzard]

1. Is the concurrent arraylist needed in HelpSystemHelper or would a normal one work as well?

Yes, the lambda can be invoked from multiple different threads and also concurrently.

2. The event.getMember seems to be @nullable, should I care? because the filesharing feature didnt care as well

What does the javadoc (or source code) say? When will it be null? Once you checked that, is the situation a situation u want to support, or do you consider the situation a bug/impossible?

[SquidXTV]

It says this:

This is null if the interaction is not from a guild.

What is a guild in this context?

[Zabuzard]

It says this:

This is null if the interaction is not from a guild.

What is a guild in this context?

Guild = Server

Think about buttons in a DM only conversation. Then you have no server-context.

Member = User + in a Server

There is also event.getUser() to get it without the server-context. Which is not nullable.

[ankitsmt211]

What is a guild in this context?

Guild refers to "server" from what I know.

[SquidXTV]

Though I need a Member to check the roles.
Can I ignore it because it will not be null

[Zabuzard]

Though I need a Member to check the roles. Can I ignore it because it will not be null

You are wording this wrong. It is not about ignoring it. It is about explicitly demanding that it must not be null.

I.e. if it is null, you consider it as fatal error / programmer bug. And what should happen for bugs? Crash! So implicitly invoking a NPE is a deliberate choice and the correct design.

Although unecessary, you can make this even more explicit by saying Objects.requireNonNull(foo).bar() instead of foo.bar().

[SquidXTV]

Though I need a Member to check the roles. Can I ignore it because it will not be null

You are wording this wrong. It is not about ignoring it. It is about explicitly demanding that it must not be null.

I.e. if it is null, you consider it as fatal error / programmer bug. And what should happen for bugs? Crash! So implicitly invoking a NPE is a deliberate choice and the correct design.

Although unecessary, you can make this even more explicit by saying Objects.requireNonNull(foo).bar() instead of foo.bar().

yeah sorry I was in school lol
didnt have much time thinking about how to write it, thanks

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Zabuzard]

has been approved since 2 weeks. will be merged now.