-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer Feature reopen #905
Conversation
in ur PR description, please add pictures of the entire flow and all edge cases, so that i can review UX, thanks. |
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
Messed up with the last merge for "java version bump", wasted couple of hours fixing that. Really need to get a grip of git. Did most of the requested changes. Would appreciate a review, hopefully didn't break anything. |
Pulling tags by id works only if forum has that tag, so is it safe to assume that there will always be a match? if not should i handle that maybe with try catch or something and a log maybe? |
yes just log it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX:
-
In the question thread, change the order of the two messages, rephrase and add embed:
@John has a question:
embed with authors profile picture, name and the message content
-
DM message, rephrase:
Hello 👋 You have asked a question on Together Java in the wrong channel
Not a big deal, but none of the experts who could help you are reading your question there 🙁Your question has been automatically transferred to #questions-foo-bar, please continue there. You might also want to give #welcome a quick read, thank you 👍
- rephase confirmation:
Transferred to #questions-foo-bar
- rephrase DM failure:
Hello
@John
👋 You have asked a question in the wrong channel
Not a big deal, but none of the experts who could help you are reading your question there 🙁Your question has been automatically transferred to #questions-foo-bar, please continue there. You might also want to give #welcome a quick read, thank you 👍
* post created are of embed type * user responses are improved * confirmation message improved
@Zabuzard You didn't update if perms will be handled from server or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, prefer "...".formatted(...)
over String.format("...", ...)
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
Just checked, its configurable in Discord 👍 |
is there any specific reason to use one over the other? |
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
Can you keep the pics in the PR description up2date? For example, how does the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitsmt211 could you share a picture of the modal with every content erased, so that i can read the "background text" on each field please? thanks |
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Show resolved
Hide resolved
good job, thank you for ur efforts 😃 |
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
...cation/src/main/java/org/togetherjava/tjbot/features/moderation/TransferQuestionCommand.java
Outdated
Show resolved
Hide resolved
congrats 🎉 lets try it out on the test server |
on a sidenote, third time is the charm
UPDATED
Step 1: Text in chat
Step 2: Transfer Command
Step 3: Modal prefilled with values
Step 4: selecting transfer-question creates a new post in helper forum
Step 5: followed by DMing User (contains guildName at last)
Step 6: deletes original Message
Incase of failed DM: