Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Feature reopen #905

Merged
merged 23 commits into from
Oct 20, 2023
Merged

Transfer Feature reopen #905

merged 23 commits into from
Oct 20, 2023

Conversation

ankitsmt211
Copy link
Member

@ankitsmt211 ankitsmt211 commented Sep 28, 2023

  • Adds a transfer feature for moderation team
  • when used, creates a new post in helper forum
  • DM user about this infraction
  • Delete original message from source channel
  • Sends original message to source on dm fail
  • resolves Transfer question Context Command #868

on a sidenote, third time is the charm

UPDATED
Step 1: Text in chat

text-sent

Step 2: Transfer Command

select-transfer-command

Step 3: Modal prefilled with values
image

Step 4: selecting transfer-question creates a new post in helper forum

image

Step 5: followed by DMing User (contains guildName at last)

image

Step 6: deletes original Message

Incase of failed DM:

image

@ankitsmt211 ankitsmt211 requested review from a team as code owners September 28, 2023 09:32
@ankitsmt211
Copy link
Member Author

Including this comment from issue, related to this PR
image

@ankitsmt211 ankitsmt211 self-assigned this Oct 4, 2023
@ankitsmt211 ankitsmt211 added enhancement New feature or request priority: normal labels Oct 4, 2023
@Zabuzard
Copy link
Member

Zabuzard commented Oct 5, 2023

in ur PR description, please add pictures of the entire flow and all edge cases, so that i can review UX, thanks.

@ankitsmt211
Copy link
Member Author

Messed up with the last merge for "java version bump", wasted couple of hours fixing that. Really need to get a grip of git. Did most of the requested changes.

Would appreciate a review, hopefully didn't break anything.

@ankitsmt211
Copy link
Member Author

@Taz03
image

Pulling tags by id works only if forum has that tag, so is it safe to assume that there will always be a match? if not should i handle that maybe with try catch or something and a log maybe?

@ankitsmt211 ankitsmt211 closed this Oct 7, 2023
@ankitsmt211 ankitsmt211 reopened this Oct 7, 2023
@Taz03
Copy link
Member

Taz03 commented Oct 7, 2023

if not should i handle that maybe with try catch or something and a log maybe?

yes just log it

Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX:

  1. In the question thread, change the order of the two messages, rephrase and add embed:
    @John has a question:
    embed with authors profile picture, name and the message content

  2. DM message, rephrase:

Hello 👋 You have asked a question on Together Java in the wrong channel
Not a big deal, but none of the experts who could help you are reading your question there 🙁

Your question has been automatically transferred to #questions-foo-bar, please continue there. You might also want to give #welcome a quick read, thank you 👍

  1. rephase confirmation:

Transferred to #questions-foo-bar

  1. rephrase DM failure:

Hello @John 👋 You have asked a question in the wrong channel
Not a big deal, but none of the experts who could help you are reading your question there 🙁

Your question has been automatically transferred to #questions-foo-bar, please continue there. You might also want to give #welcome a quick read, thank you 👍

* post created are of embed type
* user responses are improved
* confirmation message improved
@ankitsmt211
Copy link
Member Author

@Zabuzard You didn't update if perms will be handled from server or not.

Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, prefer "...".formatted(...) over String.format("...", ...)

@Zabuzard
Copy link
Member

Zabuzard commented Oct 9, 2023

@Zabuzard You didn't update if perms will be handled from server or not.

Just checked, its configurable in Discord 👍

@ankitsmt211
Copy link
Member Author

btw, prefer "...".formatted(...) over String.format("...", ...)

is there any specific reason to use one over the other?

@ankitsmt211
Copy link
Member Author

Embed after changes
image

@Zabuzard
Copy link
Member

Can you keep the pics in the PR description up2date? For example, how does the @John has a question: <embed> look like?

Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modal review

@Zabuzard
Copy link
Member

@ankitsmt211 could you share a picture of the modal with every content erased, so that i can read the "background text" on each field please? thanks

Zabuzard
Zabuzard previously approved these changes Oct 18, 2023
@Zabuzard
Copy link
Member

good job, thank you for ur efforts 😃

@Zabuzard Zabuzard merged commit fba9265 into Together-Java:develop Oct 20, 2023
9 checks passed
@Zabuzard
Copy link
Member

congrats 🎉 lets try it out on the test server

@Zabuzard Zabuzard mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer question Context Command
5 participants