Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch error when unable to send DM #909

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

christolis
Copy link
Member

Fixes #797. I was unable to test this, but I think this might be a solid solution.

@christolis christolis requested review from a team as code owners October 7, 2023 22:56
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2023

CLA assistant check
All committers have signed the CLA.

@SquidXTV
Copy link
Member

SquidXTV commented Oct 7, 2023

you can maybe instead supply null for the success Consumer.
not sure if its better/cleaner code then though

success - The success callback that will be called at a convenient time for the API. (can be null to use default)

https://docs.jda.wiki/net/dv8tion/jda/api/requests/RestAction.html#queue(java.util.function.Consumer,java.util.function.Consumer)

@surajkumar
Copy link
Contributor

surajkumar commented Oct 7, 2023

Maybe we can have the users name in the log message? Though not too important. Maybe the log message itself can be improved

@SquidXTV
Copy link
Member

SquidXTV commented Oct 7, 2023

Maybe we can have the users name in the log message? Though not too important

wont it be in the exception?

SquidXTV
SquidXTV previously approved these changes Oct 7, 2023
Taz03
Taz03 previously approved these changes Oct 8, 2023
@Zabuzard Zabuzard added bug Something isn't working priority: normal labels Oct 8, 2023
@christolis christolis dismissed stale reviews from Taz03 and SquidXTV via a299865 October 8, 2023 08:57
@Zabuzard Zabuzard merged commit 930e938 into Together-Java:develop Oct 8, 2023
9 checks passed
@Zabuzard Zabuzard mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AutoPruneHelperRoutine crashes on DM when DMs closed
6 participants