Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor method for generating title of forum post #932

Merged
merged 2 commits into from
Oct 24, 2023
Merged

refactor method for generating title of forum post #932

merged 2 commits into from
Oct 24, 2023

Conversation

ankitsmt211
Copy link
Member

@ankitsmt211 ankitsmt211 commented Oct 24, 2023

createTitle method in TransferCommand class was generating a lot of "Untitled" titles as most titles were being rejected due to a minor bug. Now the titles are generated properly.

titles generated on last 5 transfered questions:
image

@ankitsmt211 ankitsmt211 requested review from a team as code owners October 24, 2023 09:15
@ankitsmt211 ankitsmt211 self-assigned this Oct 24, 2023
@ankitsmt211 ankitsmt211 added bug Something isn't working priority: normal labels Oct 24, 2023
Taz03
Taz03 previously approved these changes Oct 24, 2023
…ration/TransferQuestionCommand.java

Co-authored-by: Daniel Tischner <zabuza.dev@gmail.com>
@Zabuzard Zabuzard merged commit 0590b36 into Together-Java:develop Oct 24, 2023
9 checks passed
@ankitsmt211 ankitsmt211 deleted the bug-fix-untitled branch November 30, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants