Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve suggestion for archived thread due to inactivity #957

Merged
merged 5 commits into from
Nov 22, 2023
Merged

improve suggestion for archived thread due to inactivity #957

merged 5 commits into from
Nov 22, 2023

Conversation

ankitsmt211
Copy link
Member

@ankitsmt211 ankitsmt211 commented Nov 20, 2023

  • more emphasis on reasons for thread inactivity

updated:

image

resolves #923

@ankitsmt211 ankitsmt211 requested review from a team as code owners November 20, 2023 18:55
@ankitsmt211 ankitsmt211 self-assigned this Nov 20, 2023
@ankitsmt211 ankitsmt211 added enhancement New feature or request priority: normal labels Nov 20, 2023
@Zabuzard
Copy link
Member

To resolve the linked issue, u also have to remove the text from the thread-opening bot response

@Zabuzard
Copy link
Member

Zabuzard commented Nov 21, 2023

I propose to rephrase as:

Your question has been closed due to inactivity.

If it was not resolved yet, feel free to just post a message below to reopen it, or create a new thread.

Note that usually the reason for nobody calling back is that your question may have been not well asked and hence no one felt confident enough answering. When you reopen the thread, try to use your time to improve the quality of the question by elaborating, providing details, context, all relevant code snippets, any errors you are getting, concrete examples and perhaps also some screenshots. Share your attempt, explain the expected results and compare them to the current results. Also try to make the information easily accessible by sharing code or assignment descriptions directly on Discord, not behind a link or pdf file; provide some guidance for long code snippets and ensure the code is well formatted and has syntax highlighting. Kindly read through https://stackoverflow.com/help/how-to-ask for more.

With enough info, someone knows the answer for sure 👍

Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see my comments)

* remove suggestion on thread creation
* improve message on thread inactivity
Taz03
Taz03 previously approved these changes Nov 21, 2023
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u share a screenshot of how it looks in action? :)

@Zabuzard
Copy link
Member

well, u already did. lol

Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 but perhaps PDF-file instead of pdf file

Taz03
Taz03 previously approved these changes Nov 21, 2023
Copy link
Member

@Taz03 Taz03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but something I just noticed is that the response does not ping OP. That causes the thread to "vanish" and OP has a hard time finding it again.

I guess a ping would be useful. Make sure that the ping is outside of the embed, in the "message", otherwise it does not actually ping.

Could you add that while at it?

@Taz03 Taz03 merged commit f4b5ebf into Together-Java:develop Nov 22, 2023
9 checks passed
@Zabuzard Zabuzard mentioned this pull request Nov 22, 2023
@ankitsmt211 ankitsmt211 deleted the improve/closed-thread-suggestion branch November 30, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: normal
Projects
None yet