chore: update permissions for get module

TogetherCrew · Dec 4, 2024 · 936c144 · 936c144
1 parent 8ab2d82
commit 936c144
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/src/controllers/community.controller.ts b/src/controllers/community.controller.ts
@@ -40,7 +40,6 @@ const getCommunity = catchAsync(async function (req: IAuthRequest, res: Response
       select: '_id name metadata disconnectedAt',
     });
     community = await communityService.populateRoles(community);
-    community = await moduleService.getActiveModulesForCommunity(community);
   }
   res.send(community);
 });

diff --git a/src/routes/v1/module.route.ts b/src/routes/v1/module.route.ts
@@ -13,7 +13,7 @@ router
 
 router
   .route('/:moduleId')
-  .get(auth('admin'), validate(moduleValidation.getModule), moduleController.getModule)
+  .get(auth('admin', 'view'), validate(moduleValidation.getModule), moduleController.getModule)
   .patch(auth('admin'), validate(moduleValidation.dynamicModuleUpdate), moduleController.updateModule)
   .delete(auth('admin'), validate(moduleValidation.deleteModule), moduleController.deleteModule);
 

diff --git a/src/services/module.service.ts b/src/services/module.service.ts
@@ -97,23 +97,12 @@ const deleteModule = async (module: HydratedDocument<IModule>): Promise<Hydrated
 interface communityWithModules extends IModule {
   modules: string[];
 }
-/**
- * Populate modules
- * @param {HydratedDocument<ICommunity>} community
- */
-const getActiveModulesForCommunity = async (community: any) => {
-  const modules = await getModulesByFilter({ community: community.id });
-  const moduleNames = [...new Set(modules.map((module) => module.name))];
-  const communityObj = community.toObject();
-  communityObj.modules = moduleNames;
-  return communityObj;
-};
+
 export default {
   createModule,
   queryModules,
   getModuleByFilter,
   getModuleById,
   deleteModule,
   updateModule,
-  getActiveModulesForCommunity,
 };