Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use env for blockchain network mode #417

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Behzad-rabiei
Copy link
Member

@Behzad-rabiei Behzad-rabiei commented Dec 4, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a new environment variable for blockchain network mode, allowing selection between 'mainnet' and 'testnet'.
    • Added constants for MAINNET_CHAIN_IDS and TESTNET_CHAIN_IDS to streamline chain ID references.
  • Improvements

    • Enhanced profile retrieval logic to dynamically select supported chain IDs based on the configured blockchain network mode.

Copy link

coderabbitai bot commented Dec 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new environment variable, BLOCKCHAIN_NETWORK_MODE, which is validated to accept only 'mainnet' or 'testnet' values. This variable is integrated into the existing Joi schema and the exported configuration object. Additionally, two new constants, MAINNET_CHAIN_IDS and TESTNET_CHAIN_IDS, are added to provide centralized references for chain IDs. The nft.service.ts file is modified to dynamically select supported chain IDs based on the blockchain network mode, enhancing the service's configurability.

Changes

File Path Change Summary
src/config/index.ts - Added BLOCKCHAIN_NETWORK_MODE: Joi.string().valid('mainnet', 'testnet').required().
- Updated exported configuration to include blockchainNetworkMode.
src/constants/chains.constant.ts - Added new constant MAINNET_CHAIN_IDS with value [42161].
- Added new constant TESTNET_CHAIN_IDS with value [84532].
src/services/nft.service.ts - Introduced conditional logic in getProfiles to select supportedChainIds based on config.blockchainNetworkMode.
- Updated import statements for MAINNET_CHAIN_IDS, TESTNET_CHAIN_IDS, and config.

Possibly related PRs

  • 404 add reputation score api endpoint #405: The changes in this PR also involve modifications to the src/config/index.ts file, specifically adding a new environment variable, which is relevant to the configuration handling similar to the changes made in the main PR regarding BLOCKCHAIN_NETWORK_MODE.

🐇 In the land of code where rabbits play,
A new mode was added to brighten the day.
Mainnet or testnet, the choice now is clear,
With constants to guide, there's nothing to fear!
So hop along, friends, let's code with delight,
For our blockchain journey is now set to flight! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 07aa94e and bb53cab.

📒 Files selected for processing (3)
  • src/config/index.ts (2 hunks)
  • src/constants/chains.constant.ts (1 hunks)
  • src/services/nft.service.ts (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Behzad-rabiei Behzad-rabiei merged commit 260940f into main Dec 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant