-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support HAT #607
feat: support HAT #607
Conversation
feat: Contributed DAT and HAT implementation for Final2x.
chore: update releases download link
Reviewer's Guide by SourceryThis PR adds support for HAT (Hybrid Attention Transformer) models and updates the core download links. The implementation involves adding new model options to the existing list and updating the download URLs for different platforms. Class diagram for updated ModelOptionsclassDiagram
class ModelOptions {
+String label
+String value
}
ModelOptions : +DAT_S_2x
ModelOptions : +DAT_S_3x
ModelOptions : +DAT_S_4x
ModelOptions : +DAT_2x
ModelOptions : +DAT_3x
ModelOptions : +DAT_4x
ModelOptions : +DAT_2_2x
ModelOptions : +DAT_2_3x
ModelOptions : +DAT_2_4x
ModelOptions : +DAT_light_2x
ModelOptions : +DAT_light_3x
ModelOptions : +DAT_light_4x
ModelOptions : +DAT_APISR_GAN_generator_4x
ModelOptions : +HAT_S_2x
ModelOptions : +HAT_S_3x
ModelOptions : +HAT_S_4x
ModelOptions : +HAT_2x
ModelOptions : +HAT_3x
ModelOptions : +HAT_4x
ModelOptions : +HAT_Real_GAN_sharper_4x
ModelOptions : +HAT_Real_GAN_4x
ModelOptions : +HAT_ImageNet_pretrain_2x
ModelOptions : +HAT_ImageNet_pretrain_3x
ModelOptions : +HAT_ImageNet_pretrain_4x
ModelOptions : +HAT_L_ImageNet_pretrain_2x
ModelOptions : +HAT_L_ImageNet_pretrain_3x
ModelOptions : +HAT_L_ImageNet_pretrain_4x
ModelOptions : -SRCNN_2x
ModelOptions : -SRCNN_3x
ModelOptions : -SRCNN_4x
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @routineLife1 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
const coreDict = { | ||
'macos-arm64': | ||
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-11-09/Final2x-core-macos-arm64.7z', | ||
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-12-14/Final2x-core-macos-arm64.7z', | ||
'macos-x64': | ||
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-11-09/Final2x-core-macos-x64.7z', | ||
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-12-14/Final2x-core-macos-x64.7z', | ||
'windows-x64': | ||
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-11-09/Final2x-core-windows-latest.7z' | ||
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-12-14/Final2x-core-windows-latest.7z' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider extracting the release date into a shared version variable
Using a shared version variable would make updates easier and reduce the risk of inconsistencies when new versions are released.
const coreDict = { | |
'macos-arm64': | |
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-11-09/Final2x-core-macos-arm64.7z', | |
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-12-14/Final2x-core-macos-arm64.7z', | |
'macos-x64': | |
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-11-09/Final2x-core-macos-x64.7z', | |
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-12-14/Final2x-core-macos-x64.7z', | |
'windows-x64': | |
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-11-09/Final2x-core-windows-latest.7z' | |
'https://github.com/Tohrusky/Final2x-core/releases/download/2024-12-14/Final2x-core-windows-latest.7z' | |
} | |
const CORE_RELEASE_VERSION = '2024-12-14' | |
const coreDict = { | |
'macos-arm64': | |
`https://github.com/Tohrusky/Final2x-core/releases/download/${CORE_RELEASE_VERSION}/Final2x-core-macos-arm64.7z`, | |
'macos-x64': | |
`https://github.com/Tohrusky/Final2x-core/releases/download/${CORE_RELEASE_VERSION}/Final2x-core-macos-x64.7z`, | |
'windows-x64': | |
`https://github.com/Tohrusky/Final2x-core/releases/download/${CORE_RELEASE_VERSION}/Final2x-core-windows-latest.7z` | |
} |
Summary by Sourcery
Introduce support for HAT models in the ModelOptions and update the Final2x-core release download links to the latest version.
New Features:
Chores: