cleanup: Add more nonnull and nullable annotations.

auto_tests/messenger_test.c

@@ -286,7 +286,9 @@ int main(void)
     options.port_range[0] = 41234;
     options.port_range[1] = 44234;
     options.log_callback = (logger_cb *)print_debug_log;
-    m = new_messenger(mono_time, &options, nullptr);
+    unsigned int err;
+    m = new_messenger(mono_time, &options, &err);
+    ck_assert(err == MESSENGER_ERROR_NONE);
 
     /* setup a default friend and friendnum */
     if (m_addfriend_norequest(m, friend_id) < 0) {

netlify.toml

@@ -5,6 +5,7 @@ command = """\
   else \
     git clone --depth=1 https://github.com/jothepro/doxygen-awesome-css;
   fi && \
+  sed -i -e 's/^non_null([^)]*) *//;s/^nullable([^)]*) *//' $(find . -name "*.[ch]") && \
   doxygen docs/Doxyfile \
   """
 publish = "_docs/html"

other/analysis/variants.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 
-run
-run -DVANILLA_NACL -I/usr/include/sodium
+run "$@"
+run -DVANILLA_NACL -I/usr/include/sodium "$@"

other/bootstrap_daemon/docker/tox-bootstrapd.sha256

@@ -1 +1 @@
-30845d5b6a5a2606afccceff83c7f1089040a800eb138c9ad92932cea2447e30  /usr/local/bin/tox-bootstrapd
+502cc22df74fa369b2c09d117176705a1e801726db6f8360c688aee90973fa22  /usr/local/bin/tox-bootstrapd

other/docker/doxygen/Dockerfile

@@ -11,6 +11,7 @@ WORKDIR /work
 COPY . /work/
 RUN cat docs/Doxyfile > Doxyfile \
  && echo "WARN_AS_ERROR = YES" >> Doxyfile \
+ && sed -i -e 's/^non_null([^)]*) *//;s/^nullable([^)]*) *//' $(find . -name "*.[ch]") \
  && doxygen Doxyfile
 
 FROM nginx:alpine

testing/Messenger_test.c

@@ -100,10 +100,11 @@ int main(int argc, char *argv[])
 
     Messenger_Options options = {0};
     options.ipv6enabled = ipv6enabled;
-    m = new_messenger(mono_time, &options, nullptr);
+    unsigned int err;
+    m = new_messenger(mono_time, &options, &err);
 
     if (!m) {
-        fputs("Failed to allocate messenger datastructure\n", stderr);
+        fprintf(stderr, "Failed to allocate messenger datastructure: %d\n", err);
         exit(0);
     }
 

toxcore/BUILD.bazel

@@ -8,11 +8,18 @@ exports_files(
     visibility = ["//c-toxcore:__pkg__"],
 )
 
+cc_library(
+    name = "attributes",
+    hdrs = ["attributes.h"],
+    visibility = ["//c-toxcore:__subpackages__"],
+)
+
 cc_library(
     name = "ccompat",
     srcs = ["ccompat.c"],
     hdrs = ["ccompat.h"],
     visibility = ["//c-toxcore:__subpackages__"],
+    deps = [":attributes"],
 )
 
 cc_library(