refactor: Use operator== for equality tests of Node_format.

It has padding bytes, so memcmp isn't necessarily safe. It is definitely
unsafe for fuzzed node formats.

toxcore/DHT_test_util.cc

@@ -17,7 +17,8 @@ Node_format random_node_format(const Random *rng)
 
 bool operator==(Node_format const &a, Node_format const &b)
 {
-    return std::memcmp(&a, &b, sizeof(Node_format)) == 0;
+    return std::memcmp(a.public_key, b.public_key, sizeof(a.public_key)) == 0
+        && a.ip_port == b.ip_port;
 }
 
 std::ostream &operator<<(std::ostream &out, Node_format const &v)

toxcore/network_test_util.cc

@@ -27,6 +27,30 @@ IP_Port random_ip_port(const Random *rng)
     return ip_port;
 }
 
+bool operator==(Family const &a, Family const &b) { return a.value == b.value; }
+
+bool operator==(IP4 const &a, IP4 const &b) { return a.uint32 == b.uint32; }
+
+bool operator==(IP6 const &a, IP6 const &b)
+{
+    return a.uint64[0] == b.uint64[0] && a.uint64[1] == b.uint64[1];
+}
+
+bool operator==(IP const &a, IP const &b)
+{
+    if (a.family != b.family) {
+        return false;
+    }
+
+    if (net_family_is_ipv4(a.family)) {
+        return a.ip.v4 == b.ip.v4;
+    } else {
+        return a.ip.v6 == b.ip.v6;
+    }
+}
+
+bool operator==(IP_Port const &a, IP_Port const &b) { return a.ip == b.ip && a.port == b.port; }
+
 std::ostream &operator<<(std::ostream &out, IP const &v)
 {
     Ip_Ntoa ip_str;

toxcore/network_test_util.hh

@@ -26,6 +26,13 @@ public:
     IP_Port operator()();
 };
 
+bool operator==(Family const &a, Family const &b);
+
+bool operator==(IP4 const &a, IP4 const &b);
+bool operator==(IP6 const &a, IP6 const &b);
+bool operator==(IP const &a, IP const &b);
+bool operator==(IP_Port const &a, IP_Port const &b);
+
 std::ostream &operator<<(std::ostream &out, IP const &v);
 std::ostream &operator<<(std::ostream &out, IP_Port const &v);