Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set _XOPEN_SOURCE to 700 for FreeBSD. #1008

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jul 16, 2018

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Jul 16, 2018
@iphydf
Copy link
Member Author

iphydf commented Jul 16, 2018

Let's do this quick-fix for now, and figure out the correct way to do enable things later.

Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@iphydf iphydf merged commit 13aa33a into TokTok:master Jul 16, 2018
@iphydf iphydf deleted the xopen-source branch July 16, 2018 17:11
@iphydf iphydf modified the milestones: v0.2.x, v0.2.4 Jul 16, 2018
@Low-power
Copy link

This break build on Solaris

/bin/sh ../libtool  --tag=CC   --mode=compile gcc-4.3.2 -std=gnu99 -DHAVE_CONFIG_H -I. -I..   -I/usr/local/include -I.. -I../toxcore   -D_REENTRANT -pthreads -g -O2 -MT ../toxcore/libtoxcore_la-network.lo -MD -MP -MF ../toxcore/.deps/libtoxcore_la-network.Tpo -c -o ../toxcore/libtoxcore_la-network.lo `test -f '../toxcore/network.c' || echo './'`../toxcore/network.c
libtool: compile:  gcc-4.3.2 -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include -I.. -I../toxcore -D_REENTRANT -pthreads -g -O2 -MT ../toxcore/libtoxcore_la-network.lo -MD -MP -MF ../toxcore/.deps/libtoxcore_la-network.Tpo -c ../toxcore/network.c  -fPIC -DPIC -o ../toxcore/.libs/libtoxcore_la-network.o
In file included from /usr/include/sys/int_types.h:55,
                 from /usr/include/sys/stdint.h:38,
                 from /usr/include/stdint.h:38,
                 from ../toxcore/logger.h:27,
                 from ../toxcore/network.h:27,
                 from ../toxcore/network.c:74:
/usr/lib/gcc/i386-pc-solaris2.11/4.3.2/include-fixed/sys/feature_tests.h:362:2: error: #error "Compiler or options invalid for pre-UNIX 03 X/Open applications  and pre-2001 POSIX applications"
make[2]: *** [../toxcore/libtoxcore_la-network.lo] Error 1
make[2]: Leaving directory `/export/home/WHR/src/toxcore-efff822/build'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/export/home/WHR/src/toxcore-efff822'
make: *** [all] Error 2

Macro _XOPEN_SOURCE can set to no more than 600 at this system.

@iphydf
Copy link
Member Author

iphydf commented May 8, 2019

@Low-power thanks for pointing that out, I'll see about porting to Solaris again soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants