Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle cleanup: Expand CONST_FUNCTION and remove the macro. #2216

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link

@restyled-io restyled-io bot commented Mar 30, 2022

A duplicate of #2212 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/TokTok/c-toxcore.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.


This change is Reviewable

iphydf and others added 2 commits March 30, 2022 20:26
Generating functions is ugly. Ideally astyle wouldn't ask us to write 4
lines of code where 1 would be more readable, but such is life (until we
move to clang-format).
@auto-add-label auto-add-label bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Mar 30, 2022
@restyled-io restyled-io bot closed this Mar 30, 2022
@restyled-io restyled-io bot deleted the restyled/pull-2212 branch March 30, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Development

Successfully merging this pull request may close these issues.

2 participants