Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fuzz support for TCP server #2367

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

sudden6
Copy link

@sudden6 sudden6 commented Dec 8, 2022

Enabling the TCP code fuzzing lead to hitting some assertions in the fuzzer support code.


This change is Reviewable

@sudden6 sudden6 modified the milestone: v0.2.19 Dec 8, 2022
@sudden6 sudden6 changed the title Fix fuzz support for TCP server fix: fuzz support for TCP server Dec 8, 2022
Copy link

@Tha14 Tha14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

I also left it running for two hours and got no asserts.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 approvals obtained

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@sudden6 sudden6 merged commit d222d70 into TokTok:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants