Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing htons call when adding configured TCP relay. #2436

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 22, 2023

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Nov 22, 2023
@iphydf iphydf marked this pull request as ready for review November 23, 2023 00:03
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (814090f) 74.48% compared to head (d1e850c) 74.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2436      +/-   ##
==========================================
- Coverage   74.48%   74.45%   -0.04%     
==========================================
  Files          87       87              
  Lines       26255    26255              
==========================================
- Hits        19557    19549       -8     
- Misses       6698     6706       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit d1e850c into TokTok:master Nov 23, 2023
53 checks passed
@iphydf iphydf deleted the htons branch November 23, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants