Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move s390x build to post-merge. #2476

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 18, 2023

It takes 15+ minutes and will very rarely fail, so it's not worth blocking PRs on it.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 18, 2023
@iphydf iphydf marked this pull request as ready for review December 18, 2023 16:42
@iphydf iphydf requested a review from a team as a code owner December 18, 2023 16:42
@iphydf iphydf changed the title gchore: Move s390x build to post-merge. chore: Move s390x build to post-merge. Dec 18, 2023
@iphydf iphydf force-pushed the s390x branch 2 times, most recently from 1c4ae2d to 3c30840 Compare December 18, 2023 16:44
It takes 15+ minutes and will very rarely fail, so it's not worth
blocking PRs on it.
Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I had to do sleep $((15*60)) && git push origin master before, once I was done with my PR and that was the only check running

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@toktok-releaser toktok-releaser merged commit 68c8276 into TokTok:master Dec 18, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants