Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Some portability/warning fixes for Windows builds. #2490

Merged
merged 1 commit into from
Dec 21, 2023
Merged

cleanup: Some portability/warning fixes for Windows builds. #2490

merged 1 commit into from
Dec 21, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 21, 2023 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Dec 21, 2023
@iphydf iphydf marked this pull request as ready for review December 21, 2023 18:02
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (425216d) 68.96% compared to head (415cb78) 69.09%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2490      +/-   ##
==========================================
+ Coverage   68.96%   69.09%   +0.13%     
==========================================
  Files          89       89              
  Lines       27769    27770       +1     
==========================================
+ Hits        19150    19187      +37     
+ Misses       8619     8583      -36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nurupo
nurupo reviewed Dec 21, 2023
View reviewed changes
toxcore/network.c Outdated Show resolved Hide resolved
@pull-request-attention pull-request-attention bot assigned iphydf and nurupo and unassigned iphydf Dec 21, 2023
@pull-request-attention pull-request-attention bot assigned iphydf and unassigned iphydf and nurupo Dec 21, 2023
@toktok-releaser toktok-releaser merged commit 415cb78 into TokTok:master Dec 21, 2023
37 checks passed
@iphydf iphydf deleted the w32 branch December 22, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nurupo nurupo nurupo left review comments

@Green-Sky Green-Sky Green-Sky approved these changes

Assignees

@iphydf iphydf

Labels
None yet
Milestone
v0.2.19
Development

Successfully merging this pull request may close these issues.
4 participants
@iphydf @nurupo @Green-Sky @toktok-releaser