Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make tox-bootstrapd use bool instead of int #2692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Mar 29, 2024

  1. refactor: Make tox-bootstrapd use bool instead of int

    A continuation of the cleanup done in
    b7404f2.
    
    tox-bootrstrapd historically had used ints for boolean values, as it was
    initially written in C89 which has no stdbool.h. Since then it has
    modernized and moved on to using C11, but the usage of the int type to
    represent boolean values, "boolean ints", remained. Recently, driven by
    a desire to eliminate implicit int-to-bool conversion, @iphydf did a
    cleanup in b7404f2, changing some of
    the boolean ints to bools and doing manual int-to-bool conversion on the
    remaining boolean ints. This left the codebase in an inconsistent state
    of both ints and bools now being used to represent boolean values, not
    to mention that the explicit int-to-bool conversions are a bit ugly. The
    only boolean ints that remained are those stemming from libconfig's
    config_lookup_bool() taking an *int parameter to return a boolean value,
    as libconfig still uses C89. This commit adds a wrapper function around
    libconfig's config_lookup_bool() that takes a *bool instead, eliminating
    the remaining boolean ints and majority of the explicit int-to-bool
    conversions in tox-bootstrapd.
    nurupo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    395e048 View commit details
    Browse the repository at this point in the history