-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Net_Crypto a module-private type. #689
Conversation
Reviewed 26 of 26 files at r1. auto_tests/onion_test.c, line 482 at r1 (raw file):
You are passing auto_tests/onion_test.c, line 484 at r1 (raw file):
You are passing toxcore/onion_client.c, line 591 at r1 (raw file):
The second toxcore/onion_client.c, line 851 at r1 (raw file):
You are passing the public key when you need to be passing the secret key. toxcore/onion_client.c, line 918 at r1 (raw file):
You are passing the public key when you need to be passing the secret key toxcore/onion_client.c, line 1072 at r1 (raw file):
You are passing the public key when you should be passing the secret key. toxcore/onion_client.c, line 1128 at r1 (raw file):
You are passing the public key when you should be passing the secret key. toxcore/onion_client.c, line 1160 at r1 (raw file):
You are passing the public key when you should be passing the secret key. Comments from Reviewable |
Reviewed 26 of 26 files at r1. Comments from Reviewable |
c5e6842
to
6a943ea
Compare
Review status: 3 of 7 files reviewed at latest revision, 8 unresolved discussions, some commit checks pending. auto_tests/onion_test.c, line 482 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
Done. auto_tests/onion_test.c, line 484 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
Done. toxcore/onion_client.c, line 591 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
Done. toxcore/onion_client.c, line 851 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
Done. toxcore/onion_client.c, line 918 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
Done. toxcore/onion_client.c, line 1072 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
Done. toxcore/onion_client.c, line 1128 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
Done. toxcore/onion_client.c, line 1160 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
Done. Comments from Reviewable |
Reviewed 5 of 5 files at r2. toxcore/onion_client.c, line 1128 at r1 (raw file): Previously, iphydf wrote…
This one wasn't fixed. Comments from Reviewable |
6a943ea
to
22db2b9
Compare
Review status: 5 of 7 files reviewed at latest revision, 1 unresolved discussion. toxcore/onion_client.c, line 1128 at r1 (raw file): Previously, endoffile78 (Endoffile) wrote…
*siiiiigh* done. Don't do many things at the same time, especially not unrelated things. This is iphy being bad at multitasking. Comments from Reviewable |
Reviewed 3 of 3 files at r3. Comments from Reviewable |
This change is