-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes about group identity and AV #15
Conversation
|
It failed to build: https://travis-ci.org/TokTok/go-toxcore-c/builds/394161119#L1075 maybe rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 2 of 3 files at r3, 3 of 3 files at r4.
Reviewable status: complete! 1 of 1 LGTMs obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r6, 2 of 3 files at r7, 3 of 3 files at r8.
Reviewable status: complete! 1 of 1 LGTMs obtained
toxav.go, line 318 at r8 (raw file):
} func (this *Tox) AddAVGroupChat(cbfn cb_audio_ftype) uint32 {
This change needs an update to group_test.go
.
This change is