feat: Some extensions to the syntax. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-add-label
bot
added
the
enhancement
iphydf
force-pushed
the
syntax
branch
2 times, most recently
from
834e5d8 to
f66bad4
Compare
* `static_assert` is now allowed inside functions. * `sizeof` can now contain any expression, not just constant expressions. E.g. `sizeof(++*foo)` is allowed in principle in the syntax. Tokstyle may later check this for sanity, but we want to use `static_assert(sizeof(expr) == sizeof(other_expr), ...)` with non-constexprs. * Tokstyle exclusions are now recorded as comments so we can reproduce them in pretty-printing. * `GNU_PRINTF` is now supported in the AST. * Multi-line macro body printing now works correctly (with `\\` at eol).
JFreegman
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
iphydf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
static_assertis now allowed inside functions.sizeofcan now contain any expression, not just constant expressions. E.g.sizeof(++*foo)is allowed in principle in the syntax. Tokstyle may later check this for sanity, but we want to usestatic_assert(sizeof(expr) == sizeof(other_expr), ...)with non-constexprs.GNU_PRINTFis now supported in the AST.This change is