Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove settings.yml in favour of hs-github-tools. #178

Merged
merged 1 commit into from
Jan 3, 2024
Merged

chore: Remove settings.yml in favour of hs-github-tools. #178

merged 1 commit into from
Jan 3, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 2, 2024

Centralised settings means we can update them without having to pass all the CI checks of each repo.


This change is Reviewable

@iphydf iphydf added this to the master milestone Jan 2, 2024
@iphydf iphydf requested a review from a team as a code owner January 2, 2024 14:07
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afc9d62) 66.25% compared to head (f874ae9) 66.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files           8        8           
  Lines        1544     1544           
=======================================
  Hits         1023     1023           
  Misses        521      521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Centralised settings means we can update them without having to pass all
the CI checks of each repo.
@iphydf iphydf merged commit f874ae9 into TokTok:master Jan 3, 2024
13 checks passed
@iphydf iphydf deleted the rm-settings-yml branch January 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants