Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Re-enable tests on windows. #154

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 25, 2024

Some of these aren't working still.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Nov 25, 2024
@github-actions github-actions bot added the test Adding missing tests, refactoring tests; no production code change label Nov 25, 2024
@iphydf iphydf force-pushed the win-tests branch 2 times, most recently from d36acf1 to 74c4e02 Compare November 25, 2024 01:11
@iphydf iphydf requested a review from a team as a code owner November 25, 2024 01:11
@nurupo
Copy link
Member

nurupo commented Nov 25, 2024

What do you mean "can't find Qt plugin DLLs"? Just put the needed plugin dlls in appropriate directories alongside the .exe file. Plugin dlls typically have their own directories, e.g. platforms, imageformats, iconengines, etc. - you can see a qtox windows release zip having those.

Also, you might need to enable building of the specific plugin in the Windows Qt cross-compilation config if the Qt plugin dll is not being built in the first place.

@iphydf iphydf force-pushed the win-tests branch 6 times, most recently from 8989adb to d542834 Compare November 26, 2024 14:25
@iphydf
Copy link
Member Author

iphydf commented Nov 26, 2024

What do you mean "can't find Qt plugin DLLs"? Just put the needed plugin dlls in appropriate directories alongside the .exe file. Plugin dlls typically have their own directories, e.g. platforms, imageformats, iconengines, etc. - you can see a qtox windows release zip having those.

Also, you might need to enable building of the specific plugin in the Windows Qt cross-compilation config if the Qt plugin dll is not being built in the first place.

What I mean is that the tests running on CI don't find the plugins because they don't know that we magically put them into /export. Our setup and zip do know that because we coded that into the setup/zip script.

@nurupo
Copy link
Member

nurupo commented Dec 5, 2024

My understanding is that Qt looks for plugins in hardcoded directories alongside the .exe file. So just put the needed plugin dlls in appropriate directories alongside the tests .exe files and the problem is solved, the tests would be able to find the plugins.

Apparently setting QT_PLUGIN_PATH should work too, didn't know of that env variable, that looks like a better way of doing that too rather than copying/symlinking the plugin dirs.

@iphydf iphydf force-pushed the win-tests branch 4 times, most recently from 3961a02 to e6a3931 Compare December 9, 2024 15:07
cmake/Testing.cmake Outdated Show resolved Hide resolved
@pull-request-attention pull-request-attention bot assigned iphydf and unassigned Green-Sky Dec 9, 2024
@iphydf iphydf changed the title test: Re-enable some tests on windows. test: Re-enable tests on windows. Dec 9, 2024
Some of these aren't working still, mainly because they can't find Qt
plugin DLLs.
@pull-request-attention pull-request-attention bot assigned iphydf and unassigned Green-Sky Dec 9, 2024
@iphydf iphydf merged commit 184796e into TokTok:master Dec 9, 2024
23 checks passed
@iphydf iphydf deleted the win-tests branch December 9, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding missing tests, refactoring tests; no production code change
Development

Successfully merging this pull request may close these issues.

3 participants