Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Make ToxId move-only. #175

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 30, 2024

We never copy it except in one place where it's a mistake.

Also removed an unimplemented member function declaration from ToxId.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Nov 30, 2024
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Nov 30, 2024
@iphydf iphydf modified the milestones: v1.18.0, v1.18.1 Dec 1, 2024
@iphydf iphydf modified the milestones: v1.18.1, v1.18.x Jan 1, 2025
@iphydf iphydf modified the milestones: v1.18.x, v1.18.2 Jan 6, 2025
We never copy it except in one place where it's a mistake.

Also removed an unimplemented member function declaration from ToxId.
@toktok-releaser toktok-releaser merged commit b946027 into TokTok:master Jan 6, 2025
32 checks passed
@iphydf iphydf deleted the move-toxid branch January 6, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Development

Successfully merging this pull request may close these issues.

3 participants