fix: Fix use-after-free when closing qTox during a call. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
iphydf
force-pushed
the
use-after-free
branch
from
626a100 to
7381ccd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 11.05% 11.05% -0.01%
==========================================
Files 292 294 +2
Lines 21223 21231 +8
==========================================
Hits 2347 2347
- Misses 18876 18884 +8 ☔ View full report in Codecov by Sentry. |
You shouldn't iterate over a container and modify it at the same time (unless you do `it = c.erase(...)` which this code can't do, and you can't do in range-for anyway.
iphydf
force-pushed
the
use-after-free
branch
from
7381ccd to
6da12d6
Compare
nurupo
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You shouldn't iterate over a container and modify it at the same time (unless you do
it = c.erase(...)which this code can't do, and you can't do in range-for anyway.Fixes #180.
This change is