chore: Build all deps including Qt statically on macOS. #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
In accordance with the static build on CI. This makes local testing agree with CI checks.
iphydf
force-pushed
the
macos-static-qt
branch
12 times, most recently
from
644de08 to
1f4022e
Compare
This way we can avoid the buggy macdeployqt entirely. Unfortunately, CrowdStrike doesn't like the modified binaries it produces and kills qTox on startup (unless running in `lldb`).
iphydf
force-pushed
the
macos-static-qt
branch
from
1f4022e to
5b0e3e5
Compare
Green-Sky
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can avoid the buggy macdeployqt entirely. Unfortunately, CrowdStrike doesn't like the modified binaries it produces and kills qTox on startup (unless running in
lldb).Related: Mozilla-Ocho/llamafile#14
Requires:
This change is