Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add logging category to debug log. #256

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 19, 2024

This is useful to distinguish log sources. In the future, we can use this to e.g. make more verbose logging optional or allow category-filtering in the debug log view.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Dec 19, 2024
@github-actions github-actions bot added the refactor Refactoring production code, eg. renaming a variable, not affecting semantics label Dec 19, 2024
@iphydf iphydf force-pushed the log-category branch 5 times, most recently from 51549c3 to 725bc7b Compare December 20, 2024 13:59
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 10.98%. Comparing base (d74a0ca) to head (725bc7b).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/model/debug/debuglogmodel.cpp 0.00% 11 Missing ⚠️
src/appmanager.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   11.06%   10.98%   -0.09%     
==========================================
  Files         294      293       -1     
  Lines       21258    21447     +189     
==========================================
+ Hits         2353     2356       +3     
- Misses      18905    19091     +186     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is useful to distinguish log sources. In the future, we can use
this to e.g. make more verbose logging optional or allow
category-filtering in the debug log view.
@toktok-releaser toktok-releaser merged commit 4b29cb6 into TokTok:master Dec 20, 2024
25 checks passed
@iphydf iphydf deleted the log-category branch December 20, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Development

Successfully merging this pull request may close these issues.

3 participants