Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Use mutex lockers where possible in video frame handling. #275

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 21, 2024

There's a deadlock somewhere in here. I'm not sure how it happens, yet, but this will at least mostly eliminate the possibility of forgotten unlocks.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Dec 21, 2024
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Dec 21, 2024
@iphydf iphydf force-pushed the mutex-locker branch 3 times, most recently from 4fc5555 to 581a678 Compare December 21, 2024 17:50
There's a deadlock somewhere in here. I'm not sure how it happens, yet,
but this will at least mostly eliminate the possibility of forgotten
unlocks.
@toktok-releaser toktok-releaser merged commit 50059ea into TokTok:master Dec 21, 2024
24 checks passed
@iphydf iphydf deleted the mutex-locker branch December 21, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Development

Successfully merging this pull request may close these issues.

3 participants