Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve performance of video frame buffering. #276

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 21, 2024

This hashtable used std::function dispatch to a function pointer for no good reason. It could have just used the function pointer instead. Now we use neither and statically bind the hash function to the hash map.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Dec 21, 2024
@github-actions github-actions bot added the performance A code change that improves performance label Dec 21, 2024
This hashtable used std::function dispatch to a function pointer for no
good reason. It could have just used the function pointer instead. Now
we use neither and statically bind the hash function to the hash map.
@toktok-releaser toktok-releaser merged commit ffcef56 into TokTok:master Dec 24, 2024
25 checks passed
@iphydf iphydf deleted the fb-hash branch December 24, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A code change that improves performance
Development

Successfully merging this pull request may close these issues.

3 participants