fix: Disable video device selection box during call. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
Green-Sky
approved these changes
Dec 21, 2024
iphydf
force-pushed
the
avoid-video-change-in-call
branch
from
02811a4 to
ddc7793
Compare
There's a crashing bug in the AV code caused by changing the video device during a call. The fix for that is non-trivial. In the meantime, we disallow such changes to make sure users don't crash themselves.
iphydf
force-pushed
the
avoid-video-change-in-call
branch
from
ddc7793 to
527c909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a crashing bug in the AV code caused by changing the video device during a call. The fix for that is non-trivial. In the meantime, we disallow such changes to make sure users don't crash themselves.
See #281
This change is