Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Clarify what the "blacklist" does in privacy. #285

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Dec 21, 2024

Renamed it to "Conference block list". Without the tooltip, it was unclear to me what it does. Also the tooltip was inverted. We don't filter by key, we filter out by key.


This change is Reviewable

@iphydf iphydf added this to the v1.18.0 milestone Dec 21, 2024
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Dec 21, 2024
@iphydf iphydf force-pushed the blocklist branch 2 times, most recently from d5450e9 to cfa8489 Compare December 22, 2024 00:08
@iphydf iphydf force-pushed the blocklist branch 2 times, most recently from 66c9053 to 0953c84 Compare December 22, 2024 16:55
Renamed it to "Conference block list". Without the tooltip, it was
unclear to me what it does. Also the tooltip was inverted. We don't
filter by key, we filter *out* by key.
@toktok-releaser toktok-releaser merged commit 38431ab into TokTok:master Dec 22, 2024
24 checks passed
@iphydf iphydf deleted the blocklist branch December 22, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Development

Successfully merging this pull request may close these issues.

3 participants