fix: Avoid hanging when capture device permissions denied on macOS. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
iphydf
force-pushed
the
no-hang-on-perms
branch
17 times, most recently
from
95b45b6 to
75a357b
Compare
This would happen e.g. on activating screen capture, but then denying permissions for it in the popup dialog. This doesn't exactly hang the program, but prevents any further changes to the capture device setting, and will hang the program on shutdown (in the destructor of the camera device).
iphydf
force-pushed
the
no-hang-on-perms
branch
from
75a357b to
52d8c6d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 11.03% 11.02% -0.01%
==========================================
Files 294 296 +2
Lines 21449 21442 -7
==========================================
- Hits 2366 2365 -1
+ Misses 19083 19077 -6 ☔ View full report in Codecov by Sentry. |
Green-Sky
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would happen e.g. on activating screen capture, but then denying permissions for it in the popup dialog. This doesn't exactly hang the program, but prevents any further changes to the capture device setting, and will hang the program on shutdown (in the destructor of the camera device).
The drive-by cleanups seem to have fixed the crash when changing video devices as well.
This change is