Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cmake AUTORCC_OPTIONS global setting #431

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

hizani
Copy link

@hizani hizani commented Jan 12, 2025

The problem is the same as #423. The option doesn't apply without CMAKE_ prefix.


This change is Reviewable

@github-actions github-actions bot added the bug Bug fix for the user, not a fix to a build script label Jan 12, 2025
@iphydf iphydf added this to the v1.18.2 milestone Jan 12, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@iphydf iphydf merged commit 80f7cbb into TokTok:master Jan 12, 2025
32 checks passed
@iphydf
Copy link
Member

iphydf commented Jan 12, 2025

Thanks, I had to make some more changes to it because the flags didn't actually work.

@hizani
Copy link
Author

hizani commented Jan 12, 2025

@iphydf Wouldn't it be better to change format-version flag from 1 to 3 and keep much faster zstd default compression algo? If I understand correctly, the project is fully migrated to QT6, so we can enable the new format version without problems.

@iphydf
Copy link
Member

iphydf commented Jan 12, 2025

I'm ok with that, but the reason we kept format version 1 was the reproducible builds. I'm not to worried about that in the cmake builds, so we can move to 3 and use zstd.

@hizani hizani deleted the fix-build-rcc branch January 12, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script
Development

Successfully merging this pull request may close these issues.

None yet

2 participants